Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ListEvaluationHistory to use default project ID #3865

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 11, 2024

Previously, this code expected the project ID to be explicitly set in the request context, which typically only happens when the client tries to override the project ID. This changes the project ID lookup to use the same logic used in the repo handler.

Change validated locally.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 11, 2024 12:43
Previously, this code expected the project ID to be explicitly set in
the request context, which typically only happens when the client tries
to override the project ID. This changes the project ID lookup to use
the same logic used in the repo handler.
@dmjb dmjb force-pushed the project-default-eval-history branch from 7bbdd0c to 6678c45 Compare July 11, 2024 12:44
@coveralls
Copy link

Coverage Status

coverage: 53.047%. remained the same
when pulling 6678c45 on project-default-eval-history
into 546457c on main.

@dmjb dmjb merged commit 4164955 into main Jul 11, 2024
20 checks passed
@dmjb dmjb deleted the project-default-eval-history branch July 11, 2024 12:53
dmjb added a commit that referenced this pull request Jul 12, 2024
Previously, this code expected the project ID to be explicitly set in
the request context, which typically only happens when the client tries
to override the project ID. This changes the project ID lookup to use
the same logic used in the repo handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants