Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListHistoryEvaluation filtering fixes. #3866

Merged

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 11, 2024

Summary

Filtering on entity name was not accounting for repo owner in case of repositories. Additionally, wrong values for enumerations were reported as internal errors rather than validation errors.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests and manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Filtering on entity name was not accounting for repo owner in case of
repositories. Additionally, wrong values for enumerations were
reported as internal errors rather than validation errors.
@blkt blkt self-assigned this Jul 11, 2024
@blkt blkt requested a review from a team as a code owner July 11, 2024 15:28
@blkt blkt merged commit 9877dba into main Jul 11, 2024
21 checks passed
@blkt blkt deleted the fix-list-evaluation-history-validation-and-repo-names-filter branch July 11, 2024 15:48
@coveralls
Copy link

Coverage Status

coverage: 53.082% (+0.04%) from 53.047%
when pulling 1080f6b on fix-list-evaluation-history-validation-and-repo-names-filter
into df6cf1c on main.

dmjb pushed a commit that referenced this pull request Jul 12, 2024
Filtering on entity name was not accounting for repo owner in case of
repositories. Additionally, wrong values for enumerations were
reported as internal errors rather than validation errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants