Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history list subcommand to CLI #3867

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add history list subcommand to CLI #3867

merged 3 commits into from
Jul 12, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 11, 2024

Summary

List the most recent entries in the evaluation history log, and allow for filtering of the results.

Note that this does not support fetching results beyond the first page at this time. That is left as future work.

Fixes #3814

Screenshot 2024-07-11 at 17 55 50

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Jul 11, 2024

Coverage Status

coverage: 53.062% (-0.02%) from 53.082%
when pulling ca9722d on history-cli-ii
into 0342f5a on main.

List the most recent entries in the evaluation history log, and allow
for filtering of the results.

Note that this does not support fetching results beyond the first page
at this time, or applying multiple values to the same filter. That is
left as future work.

Fixes #3814
@dmjb dmjb marked this pull request as ready for review July 11, 2024 16:55
@dmjb dmjb requested a review from a team as a code owner July 11, 2024 16:55
Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments, looks great so far.

cmd/cli/app/history/history_list.go Outdated Show resolved Hide resolved
cmd/cli/app/history/history_list.go Show resolved Hide resolved
@dmjb dmjb merged commit 4eb788e into main Jul 12, 2024
22 checks passed
@dmjb dmjb deleted the history-cli-ii branch July 12, 2024 09:25
dmjb added a commit that referenced this pull request Jul 12, 2024
List the most recent entries in the evaluation history log, and allow
for filtering of the results.

Note that this does not support fetching results beyond the first page
at this time, or applying multiple values to the same filter. That is
left as future work.

Fixes #3814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CLI view for evaluation history list endpoint
3 participants