Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require entity-type in profile status get to avoid permafail #3868

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented Jul 12, 2024

Summary

***Provide a brief overview of the changes and the issue being addressed.

This commit marks entity-type as required in
minder profile status get to avoide sending
ENTITY_UNSPECIFIED to the API (which always fails).

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@puerco puerco requested a review from a team as a code owner July 12, 2024 03:25
This commit marks `entity-type` as required in
`minder profile status get` to avoide sending
ENTITY_UNSPECIFIED to the API (which always fails).

Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
@coveralls
Copy link

coveralls commented Jul 12, 2024

Coverage Status

coverage: 53.073% (-0.004%) from 53.077%
when pulling a3b802e on puerco:require-type
into 9877dba on stacklok:main.

@puerco puerco merged commit c8a365a into mindersec:main Jul 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants