Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListEvaluationHistory now enforces max page size. #3873

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 12, 2024

Summary

It is currently valued at the same as the default page size. We might raise it once we have more details about the performance impact of the endpoint.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manually tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

It is currently valued at the same as the default page size. We might
raise it once we have more details about the performance impact of the
endpoint.
@blkt blkt self-assigned this Jul 12, 2024
@blkt blkt requested a review from a team as a code owner July 12, 2024 09:33
@blkt blkt merged commit 8324246 into main Jul 12, 2024
21 checks passed
@blkt blkt deleted the fix/list-evaluation-history-max-page-size-check branch July 12, 2024 09:45
dmjb pushed a commit that referenced this pull request Jul 12, 2024
It is currently valued at the same as the default page size. We might
raise it once we have more details about the performance impact of the
endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants