Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the auto_registration.entities.repository.enabled option to true when calling repo register --all #3876

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 12, 2024

Summary

When registering all repositories, what the user really means is
"register all future and current repositories. The current invocation of
the call only registered all current ones. Let's also flip the option to
register all future repositories at the same time.

Fixes: #3817

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

  1. minder provider get should either show the auto registration is set to false or not set at all
  2. minder repo register --provider=$NAME --all
  3. minder provider get again should show the auto registration is seat to true

Note: minder repo register --all currently requires the provider name to be passed. We should fix the command to iterate over providers that implement the RepoLister trait instead.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

…when calling repo register --all

When registering all repositories, what the user really means is
"register all future and current repositories. The current invocation of
the call only registered all current ones. Let's also flip the option to
register all future repositories at the same time.

Fixes: mindersec#3817
@jhrozek jhrozek requested a review from a team as a code owner July 12, 2024 13:30
@jhrozek
Copy link
Contributor Author

jhrozek commented Jul 12, 2024

@blkt 👀

@coveralls
Copy link

Coverage Status

coverage: 52.906% (-0.1%) from 53.048%
when pulling 3855a0d on jhrozek:register_all_on_provider_update
into 41e4833 on stacklok:main.

@jhrozek jhrozek merged commit 638124b into mindersec:main Jul 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic repository registration should be _all repositories and_ future repositories
3 participants