Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline token command flags not working #3879

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Fix offline token command flags not working #3879

merged 3 commits into from
Jul 15, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes the offline token command where the flags were not actually working so far.

Fixes #3875

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 12, 2024 13:49
@rdimitrov rdimitrov self-assigned this Jul 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.048%. remained the same
when pulling 366ec48 on fix-offline
into 41e4833 on main.

@JAORMX JAORMX merged commit 5d73bf7 into main Jul 15, 2024
21 checks passed
@JAORMX JAORMX deleted the fix-offline branch July 15, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minder auth offline-token command does not take into account its flags
3 participants