Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the Install Minder Server documentation #3880

Merged
merged 13 commits into from
Jul 17, 2024

Conversation

mesembria
Copy link
Contributor

@mesembria mesembria commented Jul 12, 2024

Updated the docs for installing Minder server

After talking with Evan, decided to focus on what we thought were the 2 main use cases for installing Minder server: development and production. I left the production docs (Install using Helm) alone except for minor title change.
For the development install, I tried to streamline the process, leading the user down a single path for installation (instead of giving them 5 different ways to do it), provide more clarity, and add screenshots.
The other major change is focusing solely on using a GitHub App as the provider and a breaking out the OAuth steps into a legacy doc that does not get referred to.

Fixes #3835

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Updated the docs for installation

Fixes #3835
@mesembria mesembria requested a review from a team as a code owner July 12, 2024 14:24
@mesembria mesembria linked an issue Jul 12, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jul 12, 2024

Coverage Status

coverage: 52.791% (+0.02%) from 52.769%
when pulling 331ccb4 on 3835-update-minder-install-docs
into 3be7c67 on main.

evankanderson
evankanderson previously approved these changes Jul 15, 2024
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but this is looking good!

docker-compose.yaml Show resolved Hide resolved
docs/docs/run_minder_server/config_oauth.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/config_provider.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/config_provider.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/config_webhook.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/run_the_server.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/run_the_server.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/run_the_server.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/run_the_server.md Outdated Show resolved Hide resolved
docs/docs/run_minder_server/run_the_server.md Outdated Show resolved Hide resolved
mesembria and others added 10 commits July 15, 2024 13:59
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Co-authored-by: Evan Anderson <evan@stacklok.com>
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renders fine and the updates make sense

@jhrozek jhrozek merged commit bd4ba06 into main Jul 17, 2024
22 checks passed
@jhrozek jhrozek deleted the 3835-update-minder-install-docs branch July 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Minder install docs
6 participants