Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Execution ID in the executor's evaluation param logs #3889

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jul 15, 2024

Summary

The execution ID is very handy to link together a single run when
debugging Minder. Unfortunately, it's not set everywhere... so let's do
that! This way, we'll be able to better debug minder throughout the
execution of policy for an entity.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner July 15, 2024 07:51
@JAORMX JAORMX requested a review from rdimitrov July 15, 2024 07:52
The execution ID is very handy to link together a single run when
debugging Minder. Unfortunately, it's not set everywhere... so let's do
that! This way, we'll be able to better debug minder throughout the
execution of policy for an entity.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 52.751% (+0.004%) from 52.747%
when pulling 8c9c966 on execution-id-logparams
into f1fba17 on main.

@JAORMX JAORMX merged commit a37860e into main Jul 15, 2024
21 checks passed
@JAORMX JAORMX deleted the execution-id-logparams branch July 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants