Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give metric attributes unique names #3891

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Give metric attributes unique names #3891

merged 1 commit into from
Jul 15, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 15, 2024

Summary

From experimentation, it seems that attributes of the same name in
different metrics are shared. This leads to, for example, alert status
types showing up in the remediation graph.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 15, 2024 09:44
@dmjb dmjb marked this pull request as draft July 15, 2024 09:45
From experimentation, it seems that attributes of the same name in
different metrics are shared. This leads to, for example, alert status
types showing up in the remediation graph.
@dmjb dmjb changed the title Time profile evaluation Give metric attributes unique names Jul 15, 2024
@dmjb dmjb marked this pull request as ready for review July 15, 2024 09:50
@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 52.769%. remained the same
when pulling aebd513 on time-profile-evaluation
into a37860e on main.

@dmjb dmjb merged commit 23df4b3 into main Jul 15, 2024
22 checks passed
@dmjb dmjb deleted the time-profile-evaluation branch July 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants