Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remediation/alert counter #3892

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix remediation/alert counter #3892

merged 2 commits into from
Jul 15, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 15, 2024

The code was counting them against the eval status counter

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The code was counting them against the eval status counter
@dmjb dmjb requested a review from a team as a code owner July 15, 2024 10:14
rdimitrov
rdimitrov previously approved these changes Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 52.769% (-0.009%) from 52.778%
when pulling 31428bf on fix-alert-remediation-counter
into 23df4b3 on main.

@dmjb dmjb merged commit 3be7c67 into main Jul 15, 2024
21 checks passed
@dmjb dmjb deleted the fix-alert-remediation-counter branch July 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants