Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deduplication logic in evaluation history #3893

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 15, 2024

I have run into a number of issues involving pq and sqlc's ability to deal with postgres timestamp arrays. At this point, rather than invest further effort, I have decided to remove the deduplication feature for now. Since this will only be useful at the point where we use reconciliation more extensively, I would prefer to reintroduce this functionality once we have more data to back up its utility.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

I have run into a number of issues involving pq and sqlc's ability to
deal with postgres timestamp arrays. At this point, rather than invest
further effort, I have decided to remove the deduplication feature for
now. Since this will only be useful at the point where we use
reconciliation more extensively, I would prefer to reintroduce this
functionality once we have more data to back up its utility.
@dmjb dmjb requested a review from a team as a code owner July 15, 2024 17:08
@coveralls
Copy link

Coverage Status

coverage: 52.73% (-0.04%) from 52.769%
when pulling 72851de on remove-dedupe-logic
into 3be7c67 on main.

@dmjb dmjb merged commit b57b859 into main Jul 15, 2024
26 of 27 checks passed
@dmjb dmjb deleted the remove-dedupe-logic branch July 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants