-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rule instance table in executor #3899
Merged
Merged
Commits on Jul 17, 2024
-
Use rule instance table in executor
This PR changes the executor to load rule instances from the `rule_instances` table instead of using the serialized protobufs in `entity_profiles`. Using the `rule_instances` table, a new querying method is added to load all profiles relevant to evaluation, along with the rule instances for the entity type being evaluated. Two domain-level types - `ProfileAggregate` and `RuleInstance` are defined to represent the result of these queries. I have removed a lot of the protobuf usage from the evaluation code since converting to and from protobufs just adds complexity, and the new types line up with the values and types expected by the evaluation code. Tested locally, but definitely needs some smoke testing before rollout.
Configuration menu - View commit details
-
Copy full SHA for eb9a7bf - Browse repository at this point
Copy the full SHA eb9a7bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e5583 - Browse repository at this point
Copy the full SHA b7e5583View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c3e420 - Browse repository at this point
Copy the full SHA 6c3e420View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5b6a2 - Browse repository at this point
Copy the full SHA 9e5b6a2View commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 528c7cb - Browse repository at this point
Copy the full SHA 528c7cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5add116 - Browse repository at this point
Copy the full SHA 5add116View commit details -
Configuration menu - View commit details
-
Copy full SHA for f950a55 - Browse repository at this point
Copy the full SHA f950a55View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e4cb9 - Browse repository at this point
Copy the full SHA f1e4cb9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.