Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rule instance table in executor #3899

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Use rule instance table in executor #3899

merged 8 commits into from
Jul 19, 2024

Commits on Jul 17, 2024

  1. Use rule instance table in executor

    This PR changes the executor to load rule instances from the
    `rule_instances` table instead of using the serialized protobufs in
    `entity_profiles`.
    
    Using the `rule_instances` table, a new querying method is added to load
    all profiles relevant to evaluation, along with the rule instances for
    the entity type being evaluated. Two domain-level types -
    `ProfileAggregate` and `RuleInstance` are defined to represent the
    result of these queries. I have removed a lot of the protobuf usage from
    the evaluation code since converting to and from protobufs just adds
    complexity, and the new types line up with the values and types expected
    by the evaluation code.
    
    Tested locally, but definitely needs some smoke testing before rollout.
    dmjb committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    eb9a7bf View commit details
    Browse the repository at this point in the history
  2. remove unnecessary comment

    dmjb committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b7e5583 View commit details
    Browse the repository at this point in the history
  3. clarify comment

    dmjb committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6c3e420 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9e5b6a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    528c7cb View commit details
    Browse the repository at this point in the history
  2. remove redundant comment

    dmjb committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5add116 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f950a55 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f1e4cb9 View commit details
    Browse the repository at this point in the history