Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ActionOpt types into a subpackage of profiles #3901

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 16, 2024

This change does not provide much value right now, but this will simplify the diff of an upcoming PR. Some other trivial refactoring changes from that upcoming PR have been picked here to further reduce the size of that diff.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This change does not provide much value right now, but this will
simplify the diff of an upcoming PR. Some other trivial refactoring
changes from that upcoming PR have been picked here to further reduce
the size of that diff.
@dmjb dmjb requested a review from a team as a code owner July 16, 2024 10:35
@coveralls
Copy link

coveralls commented Jul 16, 2024

Coverage Status

coverage: 53.689% (+0.002%) from 53.687%
when pulling 159e93f on rule-instance-refactor-prep
into 5acba37 on main.

@@ -22,6 +22,7 @@ import (
"encoding/json"
"errors"
"fmt"
"github.com/stacklok/minder/internal/profiles/models"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised that linter doesn't complain about unsorted imports

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be nice to sort the imports (I don't know why linter doesn't complain about that, it usually tells me to fix that), but otherwise LGTM.

@dmjb dmjb merged commit efb471b into main Jul 16, 2024
21 checks passed
@dmjb dmjb deleted the rule-instance-refactor-prep branch July 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants