Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for UpdateRole #3902

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Add tests for UpdateRole #3902

merged 1 commit into from
Jul 16, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Ref #3673

  • Add tests for UpdateRole
  • Introduce InviteService and RoleService for code separation and easier testing
  • Rename invite package to invites for consistency

I will add tests for AssignRole and RemoveRole in a later PR to keep the changes smaller.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 16, 2024 10:51
@eleftherias
Add tests for UpdateRole
46eaffa 
Ref mindersec#3673

- Add tests for UpdateRole
- Introduce InviteService and RoleService
- Rename invite package to invites
@coveralls
Copy link

coveralls commented Jul 16, 2024 •
edited
Loading

Coverage Status

coverage: 53.7% (+0.9%) from 52.829%
when pulling 46eaffa on eleftherias:3673-role-tests
into e25716e on stacklok:main.

dmjb
dmjb approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work 🎉

rdimitrov
rdimitrov approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you! 🙌

@eleftherias eleftherias merged commit cb51669 into mindersec:main Jul 16, 2024
21 checks passed
@eleftherias eleftherias deleted the 3673-role-tests branch July 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@dmjb dmjb dmjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eleftherias @coveralls @dmjb @rdimitrov