Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require the provider name when auto-enrolling repositories #3906

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Don't require the provider name when auto-enrolling repositories #3906

merged 2 commits into from
Jul 17, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 16, 2024 •
edited
Loading

Summary

We used to require the provider name when auto-enrolling for no reason
at all really. Let's just iterate over RepoLister providers
automatically instead.

Fixes: #3877

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manually

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner July 16, 2024 14:35
@jhrozek
Don't require the provider name when auto-enrolling repositories
93f2bb8 
We used to require the provider name when auto-enrolling for no reason
at all really. Let's just iterate over RepoLister providers
automatically instead.

Fixes: mindersec#3877
@coveralls
Copy link

coveralls commented Jul 16, 2024 •
edited
Loading

Coverage Status

coverage: 53.646% (-0.009%) from 53.655%
when pulling 469fe95 on jhrozek:repo_register_no_provider
into 96efacb on stacklok:main.

@jhrozek jhrozek merged commit 94d73ef into mindersec:main Jul 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmjb dmjb dmjb approved these changes

@eleftherias eleftherias eleftherias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minder repo register --all should not require the provider name to be passed
4 participants
@jhrozek @coveralls @eleftherias @dmjb