Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RemoveRole #3907

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

eleftherias
Copy link
Contributor

Summary

This adds tests for the RemoveRole handler and moves the invite and role assignment deletion logic to its respective services.

Ref #3673

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 16, 2024 14:38
@coveralls
Copy link

coveralls commented Jul 16, 2024

Coverage Status

coverage: 53.892% (+0.2%) from 53.655%
when pulling 61d9877 on eleftherias:test-remove-role
into 96efacb on stacklok:main.

@eleftherias eleftherias merged commit abb55fb into mindersec:main Jul 16, 2024
20 checks passed
@eleftherias eleftherias deleted the test-remove-role branch July 16, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants