Don't URL escape the package name when getting versions #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL-escaping is already happening within the go-github library, so we don't need to do it twice. Doing it twice causes minder to not be able to retrieve the package versions since indeed that resource is non-existent. Fixes #3914 ***Mark the type of change your PR introduces:*** - [x] Bug fix (resolves an issue without affecting existing features) - [ ] Feature (adds new functionality without breaking changes) - [ ] Breaking change (may impact existing functionalities or require documentation updates) - [ ] Documentation (updates or additions to documentation) - [ ] Refactoring or test improvements (no bug fixes or new functionality) ***Outline how the changes were tested, including steps to reproduce and any relevant configurations. Attach screenshots if helpful.*** - [x] Reviewed my own code for quality and clarity. - [x] Added comments to complex or tricky code sections. - [ ] Updated any affected documentation. - [ ] Included tests that validate the fix or feature. - [ ] Checked that related changes are merged. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
rdimitrov
approved these changes
Jul 17, 2024
dmjb
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
URL-escaping is already happening within the go-github library, so we
don't need to do it twice. Doing it twice causes minder to not be able
to retrieve the package versions since indeed that resource is non-existent.
Fixes #3914
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: