Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed option from minder history list. #3917

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 17, 2024

Summary

Option --rule-name was meant to be used as filter on rule names, but we decided not to implement it for now as its usefulness is still under discussion.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

The option was unused.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 17, 2024
@blkt blkt requested a review from a team as a code owner July 17, 2024 11:07
Option `--rule-name` was meant to be used as filter on rule names, but
we decided not to implement it for now as its usefulness is still
under discussion.
@blkt blkt force-pushed the fix/remove-unused-history-list-option branch from a512e87 to 3b9a8b1 Compare July 17, 2024 11:08
@coveralls
Copy link

coveralls commented Jul 17, 2024

Coverage Status

coverage: 54.311%. remained the same
when pulling 3b9a8b1 on fix/remove-unused-history-list-option
into fb8bd92 on main.

@blkt blkt merged commit e0b91af into main Jul 17, 2024
21 checks passed
@blkt blkt deleted the fix/remove-unused-history-list-option branch July 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants