Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cursors to minder history list. #3925

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 18, 2024

Summary

This change adds two flags to minder history list command, namely --cursor, which lets the user specify the cursor to a specific page of the list, and --size, which lets the user specify the number of items to retrieve. The two flags can be used independently from one another.

For obvious reasons, code was also added to print the cursors. I picked an arbitrary position, but reviewed the style with James to ensure some degree of uniformity with the rest of the product.

Fixes #3913

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 18, 2024
@blkt blkt requested a review from a team as a code owner July 18, 2024 08:02
This change addes two flags to `minder history list` command, namely
`--cursor`, which lets the user specify the cursor to a specific page
of the list, and `--size`, which lets the user specify the number of
items to retrieve. The two flags can be used independently from one
another.

For obvious reasons, code was also added to print the cursors. I
picked an arbitrary position, but reviewed the style with James to
ensure some degree of uniformity with the rest of the product.

Fixes #3913
@blkt blkt force-pushed the feat/cli-history-list-cursor branch from abf5864 to e104f79 Compare July 18, 2024 08:02
@coveralls
Copy link

Coverage Status

coverage: 54.389%. remained the same
when pulling e104f79 on feat/cli-history-list-cursor
into 899c6b4 on main.

@coveralls
Copy link

Coverage Status

coverage: 54.398% (+0.009%) from 54.389%
when pulling e104f79 on feat/cli-history-list-cursor
into 899c6b4 on main.

@eleftherias
Copy link
Contributor

non-blocking: Our commit guidelines suggest using the imperative mood in the commit message, so this would be "Add support..." instead of "Added support..."

@blkt blkt changed the title Added support for cursors to minder history list. Add support for cursors to minder history list. Jul 18, 2024
@blkt blkt merged commit 3518a0c into main Jul 18, 2024
23 checks passed
@blkt blkt deleted the feat/cli-history-list-cursor branch July 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for cursors to minder history list command
3 participants