Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple from/to filtering in history log RPC. #3929

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Decouple from/to filtering in history log RPC. #3929

merged 1 commit into from
Jul 24, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 18, 2024

Summary

Currently, ListEvaluationHistory RPC forces the client to either specify both from and to or none of them, but the logic behind the extracted data would allow them to be specified independently.

This change decouples from and to, making the underlying statement a tiny bit more uniform.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests and manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 18, 2024
@blkt blkt force-pushed the enh/rpc-history-list-independent-from-to branch 2 times, most recently from 4177126 to df3b0de Compare July 18, 2024 10:29
JAORMX
JAORMX previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

Base automatically changed from feat/cli-history-list-from-to to main July 19, 2024 08:39
@blkt blkt dismissed JAORMX’s stale review July 19, 2024 08:39

The base branch was changed.

@blkt blkt marked this pull request as ready for review July 23, 2024 13:22
@blkt blkt requested a review from a team as a code owner July 23, 2024 13:23
@blkt
Decouple from/to filtering in history log RPC.
c6ee7c6 
Currently, ListEvaluationHistory RPC forces the client to either
specify both from and to or none of them, but the logic behind the
extracted data would allow them to be specified independently.

This change decouples from and to, making the underlying statement a
tiny bit more uniform.
@blkt blkt force-pushed the enh/rpc-history-list-independent-from-to branch from df3b0de to c6ee7c6 Compare July 23, 2024 13:24
@coveralls
Copy link

Coverage Status

coverage: 54.213% (-0.02%) from 54.233%
when pulling c6ee7c6 on enh/rpc-history-list-independent-from-to
into 9498645 on main.

@blkt blkt merged commit ac3241f into main Jul 24, 2024
21 checks passed
@blkt blkt deleted the enh/rpc-history-list-independent-from-to branch July 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

@JAORMX JAORMX JAORMX left review comments

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blkt @coveralls @JAORMX @jhrozek