Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand profile handlers with selector support #3944

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 19, 2024

Summary

Expands the profile handlers code with adding support for selectors so
that all the usual CRUD operations on profiles work with selectors, too.

The update code is not smart - I think that's OK for now. We can
optimize later when we see that selectors are modified often.

Fixes: #3723

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manual testing + unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Expands the profile handlers code with adding support for selectors so
that all the usual CRUD operations on profiles work with selectors, too.

The update code is not smart - I think that's OK for now. We can
optimize later when we see that selectors are modified often.

Fixes: mindersec#3723
@jhrozek jhrozek requested a review from a team as a code owner July 19, 2024 19:29
@coveralls
Copy link

Coverage Status

coverage: 54.25% (+0.06%) from 54.187%
when pulling 3e2fc97 on jhrozek:selectors_handlers
into b3b3256 on stacklok:main.

@JAORMX JAORMX merged commit e1ecac5 into mindersec:main Jul 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the ProfileService with support for selectors
3 participants