Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the action overrides #3946

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Respect the action overrides #3946

merged 2 commits into from
Jul 22, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 22, 2024

PR #3899 accidentally removed a call to GetOnOffState, which allows individual actions to override the remediation and alerting status in the profile. This leads to some unusual behaviour, such as attempting to run the noop alerts and remediations instead of skipping them. This PR reinstates the calls to GetOnOffState, but changes the function to accept the ActionOpt status for that action type instead of taking a pointer to the entire profile.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

PR #3899 accidentally removed a call to GetOnOffState, which allows
individual actions to override the remediation and alerting status in
the profile. This leads to some unusual behaviour, such as attempting to
run the noop alerts and remediations instead of skipping them. This PR
reinstates the calls to GetOnOffState, but changes the function to
accept the ActionOpt status for that action type instead of taking a
pointer to the entire profile.
@dmjb dmjb requested a review from a team as a code owner July 22, 2024 08:08
@coveralls
Copy link

coveralls commented Jul 22, 2024

Coverage Status

coverage: 54.289% (+0.05%) from 54.241%
when pulling cdf5af8 on fix-action-status
into 2d785e0 on main.

@dmjb dmjb merged commit 2bb3275 into main Jul 22, 2024
21 checks passed
@dmjb dmjb deleted the fix-action-status branch July 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants