Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default security advisory alerts to Off #3947

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 22, 2024

Since we have generally received negative feedback about these alerts, do not default to On.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Since we have generally received negative feedback about these alerts,
do not default to On.
@dmjb dmjb requested a review from a team as a code owner July 22, 2024 09:59
@coveralls
Copy link

Coverage Status

coverage: 54.297%. remained the same
when pulling 84fba6f on security-advisory-default-off
into 2bb3275 on main.

@dmjb dmjb merged commit b5f9c96 into main Jul 22, 2024
23 of 24 checks passed
@dmjb dmjb deleted the security-advisory-default-off branch July 22, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants