Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure role exists before we try to remove the role assignment #3949

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR adds an additional check caught by the smoke test where Minder returned a positive response in case there was no existing role assignment and we tried to remove it.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner July 22, 2024 12:21
@rdimitrov rdimitrov self-assigned this Jul 22, 2024
@coveralls
Copy link

coveralls commented Jul 22, 2024

Coverage Status

coverage: 54.303% (+0.001%) from 54.302%
when pulling 2b69e3d on check-role-exists
into b5f9c96 on main.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit c783987 into main Jul 22, 2024
21 checks passed
@rdimitrov rdimitrov deleted the check-role-exists branch July 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants