Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop entity_profile_rules table #3963

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 23, 2024

This table is no longer used, drop it.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 23, 2024 11:54
@coveralls
Copy link

coveralls commented Jul 23, 2024

Coverage Status

coverage: 54.627%. remained the same
when pulling 029bd27 on remove-entity-profile-rules-step-ii
into c7a8e15 on main.

This table is no longer used, drop it.
@dmjb dmjb force-pushed the remove-entity-profile-rules-step-ii branch from 4424213 to bde21d6 Compare July 29, 2024 11:08
@dmjb dmjb changed the title [DO NOT MERGE] Drop entity_profile_rules table Drop entity_profile_rules table Jul 29, 2024
@dmjb dmjb merged commit e891690 into main Jul 29, 2024
24 checks passed
@dmjb dmjb deleted the remove-entity-profile-rules-step-ii branch July 29, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants