Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openfga's entity_reconcile and remote_repo_get to require the editor role #3977

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR updates openfga's entity_reconcile and remote_repo_get to require the editor role instead of admin.

The reason is we want the editor to be able to also manage repositories (based on our documentation) and currently this is not possible.

Fixes #3975

Thanks to @mesembria for flagging this! 🚀

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

…editor role

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner July 24, 2024 14:26
@rdimitrov rdimitrov self-assigned this Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 54.338% (+0.009%) from 54.329%
when pulling 18f0b21 on change-authz
into b5ec456 on main.

@JAORMX JAORMX merged commit bbbb682 into main Jul 24, 2024
21 checks passed
@JAORMX JAORMX deleted the change-authz branch July 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OpenFGA so listing/adding new repositories is allowed for the editor role
3 participants