Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_type column to evaluation_rule_entities #3980

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 24, 2024

This simplifies some queries which I am working on in another PR.

A subsequent PR will backfill the column for existing data, and make the column non-nullable.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 24, 2024 17:48
@dmjb dmjb force-pushed the entity-type-column-entity-rules-history branch from cdc117d to 553055b Compare July 24, 2024 17:49
This simplifies some queries which I am working on in another PR.
@dmjb dmjb force-pushed the entity-type-column-entity-rules-history branch from 553055b to dea54db Compare July 24, 2024 17:50
@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 54.351% (+0.01%) from 54.338%
when pulling dea54db on entity-type-column-entity-rules-history
into bbbb682 on main.

@dmjb dmjb merged commit 1ceab64 into main Jul 25, 2024
23 checks passed
@dmjb dmjb deleted the entity-type-column-entity-rules-history branch July 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants