Add profile ID to latest_evaluation_statuses
#3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this information to the `latest_evaluation_statuses` table simplifies the process of changing the profile status queries to use the evaluation history tables instead of the old tables I am trying to replace.
blkt
approved these changes
Jul 25, 2024
| -- namely: retrieving the latest rule statuses for a specific profile | ||
| -- A future PR will backfill this column and make it NOT NULL | ||
| ALTER TABLE latest_evaluation_statuses ADD COLUMN profile_id UUID REFERENCES profiles(id); | ||
| CREATE INDEX idx_profile_id ON latest_evaluation_statuses(profile_id); |
There was a problem hiding this comment.
nit: index names are global to the schema, and this might be ambiguous. Besides, if we don't use the index name anywhere, it's better off left unspecified
Suggested change
| CREATE INDEX idx_profile_id ON latest_evaluation_statuses(profile_id); | |
| CREATE INDEX ON latest_evaluation_statuses(profile_id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this information to the
latest_evaluation_statusestable simplifies the process of changing the profile status queries to use the evaluation history tables instead of the old tables I am trying to replace.Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: