Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate entity type in history log query. #3994

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 25, 2024

Summary

Entity type was added to evaluation_rule_entities table by commit 1ceab64. This introduced an ambiguity in the evaluation log query that was previously implicitly using entity type from rule_instances table. The newly introduced column is not yet filled, so we're just making the statement unambiguous by explicitly adding a reference to the table previously used.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Entity type was added to `evaluation_rule_entities` table by commit
1ceab64. This introduced an ambiguity in the evaluation log query that
was previously implicitly using entity type from `rule_instances`
table. The newly introduced column is not yet filled, so we're just
making the statement unambiguous by explicitly adding a reference to
the table previously used.
@blkt blkt added the bug Something isn't working label Jul 25, 2024
@blkt blkt self-assigned this Jul 25, 2024
@blkt blkt requested a review from a team as a code owner July 25, 2024 09:16
@blkt blkt merged commit 211f5f3 into main Jul 25, 2024
22 checks passed
@blkt blkt deleted the fix-history-log-entity-type-ambiguous branch July 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants