Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selectors.New to not return an error #3995

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 25, 2024

Summary

This is just a small refactoring that makes future patches easier to apply.

The function was only ever returning nil anyway and it would make using
it in minder easier as well

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

just make to be honest

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The function was only ever returning nil anyway and it would make using
it in minder easier as well
@jhrozek jhrozek requested a review from a team as a code owner July 25, 2024 10:14
@coveralls
Copy link

Coverage Status

coverage: 54.306% (-0.005%) from 54.311%
when pulling a8b37e9 on jhrozek:selectors_no_err_constructor
into 211f5f3 on stacklok:main.

@jhrozek jhrozek merged commit 0d7e9b8 into mindersec:main Jul 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants