Add rule_entity_id to rule_evaluations
#3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to replace the old evaluation status tables, we need to migrate any evaluation statuses to the new tables which predate the introduction of the new evaluation history tables. In order to simplify this migration, create a foreign key link from `rule_evaluations` to `evaluation_rule_entities` (the latter is essentially the new equivalent of the former). This PR also fixes some issues with the migration introduced in this previous PR.
dmjb
commented
Jul 25, 2024
|
|
||
| -- First, add an ON DELETE CASCADE to the profile_id FK | ||
| ALTER TABLE latest_evaluation_statuses DROP CONSTRAINT latest_evaluation_statuses_profile_id_fkey; | ||
| ALTER TABLE latest_evaluation_statuses |
There was a problem hiding this comment.
@JAORMX I forgot to add an ON DELETE CASCADE and I think that may have broke things
dmjb
commented
Jul 25, 2024
| ON DELETE CASCADE; | ||
|
|
||
| -- recreate index with default name | ||
| DROP INDEX IF EXISTS idx_profile_id; |
There was a problem hiding this comment.
@blkt Fixed the index name issue here
dmjb
commented
Jul 25, 2024
| @@ -129,71 +129,22 @@ func (e *executor) createOrUpdateEvalStatus( | |||
| return nil | |||
| } | |||
|
|
|||
| // Upsert evaluation | |||
There was a problem hiding this comment.
These DB queries need to happen after the write to the evaluation history table since we are now tracking the rule-entity ID. They also now are run in the same transaction as the other queries.
JAORMX
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to replace the old evaluation status tables, we need to migrate any evaluation statuses to the new tables which predate the introduction of the new evaluation history tables. In order to simplify this migration, create a foreign key link from
rule_evaluationstoevaluation_rule_entities(the latter is essentially the new equivalent of the former). A foreign key reference torule_instancesis also added, this is also to simplify the migration.This PR also fixes some issues with the migration introduced in this previous PR.
Tested locally.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: