Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PullRequest as available entity for selectors #4000

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Jul 25, 2024

Summary

This is more or less for completeness' sake. Both Ozz when reviewing the original code and Giuseppe when implementing the FE side of things were surprised that the selector API didn't handle PRs.

Fixes: #3988

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

mostly unit tests tbh

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is more or less for completeness' sake

Fixes: mindersec#3988
@jhrozek jhrozek requested a review from a team as a code owner July 25, 2024 12:10
@coveralls
Copy link

Coverage Status

coverage: 54.332% (+0.02%) from 54.316%
when pulling c72b86e on jhrozek:selectors_pull_request
into 0d7e9b8 on stacklok:main.

@jhrozek jhrozek merged commit 9f15189 into mindersec:main Jul 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile selectors - add pull request as available entity
4 participants