Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take selectors into use in executor #4004

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Take selectors into use in executor #4004

merged 7 commits into from
Jul 26, 2024

Commits on Jul 26, 2024

  1. Change the BulkGetProfilesByID DB query to return an embedded profile 

    This will make it easier to extend what the query returns
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    00334cb View commit details
    Browse the repository at this point in the history

  2. Extend the BulkGetProfilesByID DB query with selectors 

    This is to return the selectors at the same time as querying the
profiles from the DB and be able to use them in the executor.
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c7793ed View commit details
    Browse the repository at this point in the history

  3. Extend the ProfileAggregate structure with selectors 

    This returns the selectors to the engine through the ProfileAggregate
structure
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6fb293e View commit details
    Browse the repository at this point in the history

  4. Change the selector's NewSelectionFromProfile API to accept the struc… 

    …ture from the models API

This will make it easier to use the method in the executor
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0156245 View commit details
    Browse the repository at this point in the history

  5. Integrate the selectors into the executor 

    When an entity is not selected for a profile, let's save that into a
profile-global status override and use that for all the statuses instead
calling eval.

Fixes: mindersec#3724
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f23e56c View commit details
    Browse the repository at this point in the history

  6. Include which selector did unselect the entity 

    In addition to returning a bool, let's also return which selector did
shortcut the evaluation when returning false
    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    66c6987 View commit details
    Browse the repository at this point in the history

  7. Review feedback: reword confusing comment

    @jhrozek
    jhrozek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1d88d5b View commit details
    Browse the repository at this point in the history