Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local Keycloak image to match deployed config #4011

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Update the local keycloak docker image to have the same configuration as the deployed Keycloak in staging.
This makes local testing and verification more reliable.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner July 26, 2024 08:07
@coveralls
Copy link

coveralls commented Jul 26, 2024

Coverage Status

coverage: 54.437%. remained the same
when pulling 633aeb2 on eleftherias:keycloak-match-deployed
into 5707473 on stacklok:main.

dmjb
dmjb previously approved these changes Jul 26, 2024
JAORMX
JAORMX previously approved these changes Jul 26, 2024
@eleftherias eleftherias dismissed stale reviews from JAORMX and dmjb via 633aeb2 July 26, 2024 09:46
@eleftherias eleftherias merged commit b9170e5 into mindersec:main Jul 26, 2024
21 checks passed
@eleftherias eleftherias deleted the keycloak-match-deployed branch July 26, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants