Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetProfileByName RPC #4029

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add GetProfileByName RPC #4029

merged 1 commit into from
Jul 29, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jul 29, 2024

Summary

This adds a new RPC to get a profile by name, this is taken into use by
the CLI already.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner July 29, 2024 11:29
@JAORMX JAORMX requested a review from eleftherias July 29, 2024 11:33
This adds a new RPC to get a profile by name, this is taken into use by
the CLI already.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@coveralls
Copy link

coveralls commented Jul 29, 2024

Coverage Status

coverage: 54.509% (-0.1%) from 54.627%
when pulling 9072742 on get-profile-byname
into c7a8e15 on main.

@JAORMX JAORMX merged commit 6c46b59 into main Jul 29, 2024
22 checks passed
@JAORMX JAORMX deleted the get-profile-byname branch July 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants