Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill latest_evaluation_statuses with profile_id #4031

Merged
merged 1 commit into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

ALTER TABLE latest_evaluation_statuses ALTER COLUMN profile_id DROP NOT NULL;
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

BEGIN;

-- backfill rows which don't have a profile ID
UPDATE latest_evaluation_statuses
SET profile_id = ri.profile_id
FROM rule_instances AS ri
JOIN evaluation_rule_entities AS ere ON ere.rule_id = ri.id
JOIN latest_evaluation_statuses AS les ON les.rule_entity_id = ere.id
WHERE les.profile_id IS NULL;

-- make field mandatory
ALTER TABLE latest_evaluation_statuses ALTER COLUMN profile_id SET NOT NULL;

COMMIT;
6 changes: 3 additions & 3 deletions internal/db/eval_history.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/db/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/history/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@ func (_ *evaluationHistoryService) createNewStatus(
db.UpsertLatestEvaluationStatusParams{
RuleEntityID: ruleEntityID,
EvaluationHistoryID: newEvaluationID,
ProfileID: uuid.NullUUID{
UUID: profileID,
Valid: true,
},
ProfileID: profileID,
},
)
if err != nil {
Expand Down
Loading