Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config from internal to pkg #4805

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Move config from internal to pkg #4805

merged 1 commit into from
Oct 24, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Oct 24, 2024

Summary

The following PR moves the config package outside of internal to pkg.

Fixes #4698

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner October 24, 2024 08:56
@JAORMX
Copy link
Contributor

JAORMX commented Oct 24, 2024

Can you link #4698 ?

@rdimitrov rdimitrov force-pushed the move-config branch 2 times, most recently from 193e8e9 to 01212fa Compare October 24, 2024 09:16
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit 226f2fb into main Oct 24, 2024
25 checks passed
@rdimitrov rdimitrov deleted the move-config branch October 24, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move internal/config to pkg
3 participants