Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We recently changed the behaviour of
minder ruletype create
andapply
to ignore files that do not define rule types. This allowed us to add test files tomindersec/minder-rules-and-profiles
, but it in turn brokemindev
.This change makes
mindev
behave likeminder
by splitting folder walk from ruletype validation.Fixes #4819
Change Type
Mark the type of change your PR introduces:
Testing
Manually ran the following commands pre- and post-fix.
Review Checklist: