Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minder resource parsing using protojson and use it for data sources #4981

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 15, 2024

Summary

This adds a new helper utility to parse YAML using the protojson
library. This allows us to parse more complex protobuf structures such
as one-of.

Moreover, this adds the ability to parse data source YAML files.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner November 15, 2024 14:04
@coveralls
Copy link

coveralls commented Nov 15, 2024

Coverage Status

coverage: 54.736% (+0.004%) from 54.732%
when pulling 303becd on JAORMX:datasource-parse
into 290dc7d on mindersec:main.

This adds a new helper utility to parse YAML using the protojson
library. This allows us to parse more complex protobuf structures such
as `one-of`.

Moreover, this adds the ability to parse data source YAML files.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX merged commit 5f4407f into mindersec:main Nov 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants