Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ValidateRuleTypeReferences from data sources service #5077

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 28, 2024

Summary

This was not used and instead the functionality was coded on the rule
type control plane file in #5068

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This was not used and instead the functionality was coded on the rule
type control plane file.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner November 28, 2024 13:31
@JAORMX JAORMX merged commit 7f5f068 into mindersec:main Nov 28, 2024
27 checks passed
@JAORMX JAORMX deleted the rm-func-ds branch November 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants