Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Data Source ID only to check for rule type references #5121

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 3, 2024

Summary

The project ID belongs to the rule type, so we only check for the data
source ID when checking for references before attempting to delete. This
should be fairly safe as we have already checked the project ID
beforehand.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

The project ID belongs to the rule type, so we only check for the data
source ID when checking for references before attempting to delete. This
should be fairly safe as we have already checked the project ID
beforehand.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX requested a review from a team as a code owner December 3, 2024 10:33
@coveralls
Copy link

Coverage Status

coverage: 55.222% (-0.004%) from 55.226%
when pulling 08d3ef5 on JAORMX:ds-func-proj
into c7e8d6d on mindersec:main.

@rdimitrov
Copy link
Member

Ah, now I realise why this was wrong 🤦‍♂️ Thanks for fixing it! 🚀

@JAORMX JAORMX merged commit fe30177 into mindersec:main Dec 3, 2024
26 checks passed
@JAORMX JAORMX deleted the ds-func-proj branch December 3, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants