rule_type create: Add option to create multiple rule types at once or read all filed in directory
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the rule_type create command to be able to take an array of files and create each of them. The intent is to provide a more agile way of using this tool instead of having to do multiple command invocations.
This makes things simpler since we now can pass a directory
JAORMX
changed the title
JAORMX
changed the title
rule_type create: Add option to create multiple rule types at once or read all filed in directory
jhrozek
approved these changes
Aug 25, 2023
| return nil | ||
| }, | ||
| } | ||
|
|
||
| func validateFilesArg(files []string) error { |
There was a problem hiding this comment.
Would this be already useful in util?
There was a problem hiding this comment.
Maybe. I plan to migrate policy creation to a similar pattern. Mind if I move this in that PR instead?
There was a problem hiding this comment.
sure, whatever is easier for you
|
|
||
| if fi.IsDir() { | ||
| // expand directory | ||
| err := filepath.Walk(f, func(path string, info fs.FileInfo, err error) error { |
There was a problem hiding this comment.
the stdlib documentation seems to suggest that WalkDir might be faster, but at the same time I don't think it matters for our use-case
Comment on lines
+53
to
+55
| if err != nil { | ||
| return fmt.Errorf("error getting grpc connection: %w", err) | ||
| } |
There was a problem hiding this comment.
(non-blocking curiousity) Why remove util.ExitNicelyOnError? We seem to use it in a bunch of places.
Comment on lines
+99
to
+101
| if files == nil { | ||
| return fmt.Errorf("error: file must be set") | ||
| } |
There was a problem hiding this comment.
Do you want to check len(files) > 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rule_type create command to be able to take an array of files
and create each of them. The intent is to provide a more agile way of using this
tool instead of having to do multiple command invocations.
If the passed argument is a directory, it'll read all the files in the directory and create rules out of it.