Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for syncing repositories #788

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Increase timeout for syncing repositories #788

merged 1 commit into from
Aug 30, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 30, 2023

This increases the timeout for syncing repositories from gitHub into the database.

We were getting timeouts since this may be a fairly expensive operation, so a context
timeout was merited.

Closes: #787

This increases the timeout for syncing repositories from gitHub into the database.

We were getting timeouts since this may be a fairly expensive operation, so a context
timeout was merited.

Closes: #787
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we see other calls being more costly, we can generalise the expensive timeout later.

@JAORMX JAORMX merged commit a6d1681 into main Aug 30, 2023
13 checks passed
@JAORMX JAORMX deleted the sync-repo-tmout branch August 30, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout when enrolling provider
2 participants