Return why an artifact was skipped from the artifact ingester #810
Conversation
internal/engine/executor.go
Outdated
| @@ -539,6 +539,7 @@ func (e *Executor) handleArtifactPublishedEvent(ctx context.Context, prov string | |||
| } | |||
|
|
|||
| result := rte.Eval(ctx, versionedArtifact, rule.Def.AsMap(), rule.Params.AsMap()) | |||
| log.Printf("artifact eval result: %s", result) | |||
There was a problem hiding this comment.
We should also print the rule type and policy that's being evaluated. The result by itself is going to be confusing when running multiple policies.
There was a problem hiding this comment.
Do we want to pull out either zerolog here or tracing to record this, so that we're not spamming the logs during an artifact ingest? (I don't know -- I can see where this would be useful for debugging, but I can also see this getting very noisy.)
There was a problem hiding this comment.
I added zerolog to this one instance. We should probably be mindful of debugging as we write new code and I'm fine making a pass for the artifact processing since I still have it fresh in my head.
This is helpful to debug artifact evaluation
|
@JAORMX I think your comment has been addressed. |
This is helpful to debug artifact evaluation