handlers_policy: return more information on artifacts #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policy_status get was written with repositories in mind, let's also return information that pertain to artifacts Fixes: #761
JAORMX
approved these changes
Aug 31, 2023
evankanderson
approved these changes
Aug 31, 2023
| return entityInfo | ||
| } | ||
|
|
||
| // linter complaints that switches with one-case are bad, but I think that a switch is more extensible for future |
There was a problem hiding this comment.
Do you want a default case that returns the entityType.Entities?
There was a problem hiding this comment.
that's already in the struct that wraps this map:
st := &pb.RuleEvaluationStatus{
PolicyId: in.PolicyId,
RuleId: rs.RuleTypeID,
RuleName: rs.RuleTypeName,
Entity: string(rs.Entity), <-----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
policy_status get was written with repositories in mind, let's also
return information that pertain to artifacts
Fixes: #761