Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rego: Introduce file.ls which allows us to list files #829

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 4, 2023

The idea is that we can traverse the filesystem cloned by git, and, in-turn,
evaluate all traversed files. This allows us to write policies such as:

I want to verify that there is a workflow that runs code QL

We should be able to extrapolate from here and write more complex rules that
very that all files conform to something specific.

The idea is that we can traverse the filesystem cloned by git, and, in-turn,
evaluate all traversed files. This allows us to write policies such as:

	I want to verify that there is a workflow that runs code QL

We should be able to extrapolate from here and write more complex rules that
very that all files conform to something specific.
Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't help to much with the rego stuff, but other then that looks OK

@@ -3,6 +3,7 @@ owner: JAORMX
repository: auditevent
repoId: 605597568
HookUrl:
clone_url: "https://github.com/JAORMX/auditevent.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something needs doing now / not a priority; If you prefer we have something in stacklok org we can create or migrate accordingly. I am starting to create some demo / open to abuse repos: https://github.com/orgs/stacklok/repositories?q=demo&type=all&language=&sort=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having demo repos would be ideal

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not an expert on Rego, but this patch looks good and the tests are convincing.

@JAORMX JAORMX merged commit 05ccd58 into main Sep 4, 2023
13 checks passed
@JAORMX JAORMX deleted the rego-ls branch September 4, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants