refactor: Move webhook event parsing logic to webhook handler #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
changed the title
|
I replied on slack earlier but because not everyone can be up-to-date on slack conversations - I think this is a terrific refactor. We need to figure out a way to call the new eval handler on a slice of entities though to support init and reconcile handlers. |
jhrozek
reviewed
Sep 4, 2023
JAORMX
force-pushed
the
event-refactor
branch
4 times, most recently
from
ca9c0ac
to
7dc079f
Compare
JAORMX
changed the title
JAORMX
force-pushed
the
event-refactor
branch
2 times, most recently
from
0f035ec
to
7d07042
Compare
|
In case anyone is following the PRs - we did a screen-share review with Ozz and I think this is a great refactor that should go in. Once the tests are added, I think this will be ready for merge and I'll rebase my pending PR with the policy init support for artifacts atop this one to keep the code clean. |
JAORMX
force-pushed
the
event-refactor
branch
from
7d07042
to
e265567
Compare
This moves the event parsing logic to the webhook handler since that's already github specific. Instead of doing any JSON mangling on the executor side, it will expect already built events that are ready to be processed. This makes the executor lighter and allows us to add more complex logic on the webhook side (e.g. handling pull requests)
JAORMX
force-pushed
the
event-refactor
branch
from
e265567
to
075813a
Compare
JAORMX
changed the title
jhrozek
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the event parsing logic to the webhook handler since that's
already github specific. Instead of doing any JSON mangling on the executor
side, it will expect already built events that are ready to be processed.
This makes the executor lighter and allows us to add more
complex logic on the webhook side (e.g. handling pull requests)