cleanup: remove unnecessary checkups from rule #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule previously known as "actions_permissions" was a little complex in the sense that it checked a couple of attributes from the github repo configuration. This renames the rule to something more appropriate and checks for only one relevant thing. Thus making it more understandable. This also adds appropriate guidance for folks.
jhrozek
approved these changes
Sep 5, 2023
| @@ -40,10 +49,6 @@ def: | |||
| type: jq | |||
| jq: | |||
| # Ingested points to the data retrieved in the `ingest` section | |||
| - ingested: | |||
There was a problem hiding this comment.
What was the enabled checking for? Should we split that in a separate rule?
There was a problem hiding this comment.
That check wasn't actually valid as you can't really even set if a repo should have github actions enabled/disabled. You can only do so org-wide. So... it was a mis-documentation from github's side. Given that, no use checking that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule previously known as "actions_permissions" was a little complex in
the sense that it checked a couple of attributes from the github repo
configuration.
This renames the rule to something more appropriate and checks for only one relevant
thing. Thus making it more understandable.
This also adds appropriate guidance for folks.