Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migratedown target #858

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix migratedown target #858

merged 1 commit into from
Sep 5, 2023

Conversation

eleftherias
Copy link
Contributor

  • Drop all tables in SQL
  • Accommodate for KO_DATA_PATH var being unset

Fix migratedown target
e3e4ae9 
- Drop all tables in SQL
- Accommodate for KO_DATA_PATH var being unset
@JAORMX JAORMX merged commit a3960a5 into mindersec:main Sep 5, 2023
12 checks passed
@JAORMX JAORMX deleted the fix-migrate-down branch September 5, 2023 14:55
evankanderson
evankanderson reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Apparently I fixed this for migrateup but not migratedown...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@JAORMX JAORMX JAORMX approved these changes

@jhrozek jhrozek Awaiting requested review from jhrozek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleftherias @JAORMX @evankanderson